Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin cli] defer optimization #26983

Merged
merged 8 commits into from Jan 29, 2019

Conversation

Projects
None yet
5 participants
@jbudz
Copy link
Contributor

commented Dec 11, 2018

Followup to #16302. This defers the optimize step in the plugin installer to server start.

  1. support installing multiple plugins with one optimization
  2. prevent a common cause of permission issues
  3. cleanup extra code

If a pre-optimization step is wanted, e.g. to bake plugins into a docker image:

./bin/kibana-plugin install my-plugin
./bin/kibana --optimize

If not, bin/kibana will optimize on server start

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Dec 11, 2018

@mistic

mistic approved these changes Dec 11, 2018

Copy link
Member

left a comment

LGTM! @jbudz u just have some prettier errors when running eslint

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Dec 11, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Dec 11, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Dec 12, 2018

@jbudz jbudz requested a review from elastic/kibana-operations Jan 24, 2019

jbudz added some commits Jan 28, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2019

jbudz added some commits Jan 29, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2019

@jbudz jbudz merged commit 166c192 into elastic:master Jan 29, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
@gchaps

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

@jbudz Could you please add a note about this to the 7.0 Breaking Changes doc?

@jbudz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Sure! @gchaps can you clarify which breaking change docs? I have one in changelog.md and migration_7_0.md.

@jbudz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Good to go here, we discussed on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.