Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding informational callout when step_info message is present #27046

Merged

Conversation

@bmcconaghy
Copy link
Contributor

commented Dec 12, 2018

Closes #26811
Adding an informational callout when there is a step_info message:
image

You can verify this locally by creating a policy with rollover with max size 1 document, activating warm phase, setting move to warm phase on rollover to true, and setting replicas for warm phase to 6. Attach this policy to an index with name like "testy-1". You'll also want to add this setting to make things happen faster:

PUT _cluster/settings
{
  "transient": {
    "indices.lifecycle.poll_interval": "1s"
  }
}
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@bmcconaghy bmcconaghy requested a review from jen-huang Dec 12, 2018

@cjcenizal
Copy link
Contributor

left a comment

Tested locally, code LGTM!

@jen-huang
Copy link
Contributor

left a comment

Code LGTM!

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@bmcconaghy bmcconaghy merged commit 575399d into elastic:master Dec 12, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Dec 12, 2018
adding informational callout when step_info message is present (elast…
…ic#27046)

* adding informational callout when step_info message is present

* updating test and snapshot

* changing title to action status

@bmcconaghy bmcconaghy deleted the bmcconaghy:add_step_info_informational_callout branch Dec 12, 2018

bmcconaghy added a commit that referenced this pull request Dec 12, 2018
adding informational callout when step_info message is present (#27046)…
… (#27074)

* adding informational callout when step_info message is present

* updating test and snapshot

* changing title to action status
WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 18, 2018
adding informational callout when step_info message is present (elast…
…ic#27046)

* adding informational callout when step_info message is present

* updating test and snapshot

* changing title to action status

@epixa epixa added v7.0.0 and removed v7.0.0-alpha2 labels Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.