Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload full index list when reload hits missing index #27197

Conversation

bmcconaghy
Copy link
Contributor

Currently index management shows an error and cannot refresh displayed policy list if an index currently shown is deleted by another process (ILM, etc.). This PR fixes this issue by responding to the 404 error that comes out with dispatching a loadIndices call to get the whole list anew.

This can be tested locally by having index management open in one tab and in another deleting an index that is shown in the current page, then waiting for the refresh interval. You should see the current list refresh with the deleted index not present.

@bmcconaghy bmcconaghy added v7.0.0 v6.6.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 14, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a bug if the detail panel of the index being deleted is opened. A fatal error is thrown

screen shot 2018-12-14 at 14 42 15

@bmcconaghy
Copy link
Contributor Author

@sebelga Good catch, pushed a fix for this.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmcconaghy
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bmcconaghy bmcconaghy merged commit 99a5727 into elastic:master Dec 14, 2018
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Dec 14, 2018
* reload full index list when reload hits missing index

* handling open detail panel for deleted index

* copy edit
@bmcconaghy bmcconaghy deleted the fix_missing_index_reload_error_index_management branch December 14, 2018 17:46
bmcconaghy added a commit that referenced this pull request Dec 14, 2018
* reload full index list when reload hits missing index

* handling open detail panel for deleted index

* copy edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants