New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shardTimeout params to body only if not 0 #27217
Conversation
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested, that the fix doesn't set timeout
anymore when elasticsearch.shardTimeout
is 0
Pinging @elastic/kibana-app |
💚 Build Succeeded |
* Add timeout params to body only if not 0 * Add unit tests
* Add timeout params to body only if not 0 * Add unit tests
@levinsond this issue fixes the timeout problem that occurs in cloud when using Kibana. Are you are you experiencing the same warning as described in #27209? |
In 6.5.3 we experienced the warning from #27209 constantly when using Kibana. |
Summary
Fix #27209
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately