Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shardTimeout params to body only if not 0 #27217

Merged
merged 2 commits into from Dec 14, 2018

Conversation

markov00
Copy link
Member

Summary

Fix #27209

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested, that the fix doesn't set timeout anymore when elasticsearch.shardTimeout is 0

@timroes timroes added Feature:Search Querying infrastructure in Kibana v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 v6.5.4 labels Dec 14, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 merged commit ae6a4c5 into elastic:master Dec 14, 2018
markov00 added a commit to markov00/kibana that referenced this pull request Dec 14, 2018
* Add timeout params to body only if not 0

* Add unit tests
markov00 added a commit to markov00/kibana that referenced this pull request Dec 14, 2018
* Add timeout params to body only if not 0

* Add unit tests
timroes pushed a commit that referenced this pull request Dec 14, 2018
* Add timeout params to body only if not 0

* Add unit tests
timroes pushed a commit that referenced this pull request Dec 14, 2018
* Add timeout params to body only if not 0

* Add unit tests
@levinsond
Copy link

levinsond commented Dec 21, 2018

Not sure if here is the correct place for my question... Apologies in advance if it is not.
We have an ELK deployment in Elastic Cloud and we have some users analyzing data in Kibana. Since we upgraded to 6.5.4 a couple of days ago, we have had to restart the cluster several times due to Memory issues. We were doing fine with 4GB of memory but we decided to resize - upgrade to 8GB thinking this would solve the issue. It did not and we had to restart again today. Could this fix for 6.5.4 be related to our issue? I am not very technical, but I have access in Kibana to the administrator panel. Any suggestions?
screen shot 2018-12-21 at 11 00 33 am

@markov00
Copy link
Member Author

@levinsond this issue fixes the timeout problem that occurs in cloud when using Kibana. Are you are you experiencing the same warning as described in #27209?
Have you already filed a support ticket? I think it's the best place to get the right answer for this question.

@levinsond
Copy link

In 6.5.3 we experienced the warning from #27209 constantly when using Kibana.
We upgraded to 6.5.4 and now we are having the memory issues described. I also opened a support ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.5.4 v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants