Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix import modal flex items overflowing in IE11 #27529

Merged
merged 2 commits into from Dec 20, 2018

Conversation

@alvarezmelissa87
Copy link
Contributor

commented Dec 19, 2018

Summary

Adds grow={false} to FlexItem components to prevent item content overflow in IE11.

screen shot 2018-12-19 at 11 59 30 am

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

Pinging @elastic/ml-ui

@alvarezmelissa87 alvarezmelissa87 referenced this pull request Dec 19, 2018
30 of 30 tasks complete
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

@walterra
Copy link
Contributor

left a comment

LGTM

@peteharverson
Copy link
Contributor

left a comment

LGTM. In testing I noticed that the width of the Import Events modal is not wide enough on IE11 to display the full content without overflow. But this improves the usability on IE11 as a first step.

@alvarezmelissa87 alvarezmelissa87 merged commit a730d69 into elastic:master Dec 20, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Dec 20, 2018
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Dec 20, 2018

@alvarezmelissa87 alvarezmelissa87 deleted the alvarezmelissa87:ml-calendar-ie-fix branch Dec 20, 2018

WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 21, 2018
WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 21, 2018
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Dec 21, 2018
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Dec 21, 2018
alvarezmelissa87 added a commit that referenced this pull request Dec 21, 2018
[ML] Fix import modal flex items overflowing in IE11 (#27529) (#27597)
* Fix import modal for IE11

* update tests
alvarezmelissa87 added a commit that referenced this pull request Dec 21, 2018
[ML] Fix import modal flex items overflowing in IE11 (#27529) (#27598)
* Fix import modal for IE11

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.