Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes page manager for workpads without style property #27556

Merged
merged 2 commits into from Dec 20, 2018

Conversation

@cqliu1
Copy link
Contributor

commented Dec 20, 2018

Closes #27553.

This adds a fallback value for the workpad css prop in the PageManager component in case the workpad doesn't have a css property to prevent Style.it from failing.

screen shot 2018-12-19 at 5 28 04 pm

@cqliu1 cqliu1 requested a review from elastic/kibana-canvas as a code owner Dec 20, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

@w33ble

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

dec-19-2018 17-33-51

Nice. Ignore the failed elements, that's caused by something else.

duplicatePage={duplicatePage}
confirmDelete={this.confirmDelete}
/>
<div>

This comment has been minimized.

Copy link
@w33ble

w33ble Dec 20, 2018

Contributor

I thought you removed this div because it broke the page manager layout in the past...

This comment has been minimized.

Copy link
@cqliu1

cqliu1 Dec 20, 2018

Author Contributor

I removed another div higher up, but I realized that I forgot to add one here as part of #26795. style-it expects a wrapper <div> around your element you're trying to style, so it can inject an id that it uses to apply the styles. Without the div, the styles weren't being applied to the thumbnails at all, which was an unreported bug, it turns out.

This comment has been minimized.

Copy link
@w33ble

w33ble Dec 20, 2018

Contributor

Funny, just adding that div fixes the issue too. Still good to default the value though.

@w33ble w33ble added this to In Progress in Canvas (6.6 @ 12/18, 6.7 @ 01/29) via automation Dec 20, 2018

@w33ble
w33ble approved these changes Dec 20, 2018
Copy link
Contributor

left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

@cqliu1 cqliu1 merged commit 317435d into elastic:master Dec 20, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

Canvas (6.6 @ 12/18, 6.7 @ 01/29) automation moved this from In Progress to Done Dec 20, 2018

@cqliu1 cqliu1 deleted the cqliu1:fix/page-manager-style branch Dec 20, 2018

cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 20, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 20, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 20, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 20, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit that referenced this pull request Dec 20, 2018
Fixes page manager for workpads without style property (#27556) (#27627)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 21, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 21, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 21, 2018
Fixes page manager for workpads without style property (elastic#27556)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager
cqliu1 added a commit that referenced this pull request Dec 21, 2018
Fixes page manager for workpads without style property (#27556) (#27702)
* Added fallback value for workpadCSS prop

* Added fallback to value for workpad css in page manager

@cqliu1 cqliu1 restored the cqliu1:fix/page-manager-style branch Jan 3, 2019

@cqliu1 cqliu1 deleted the cqliu1:fix/page-manager-style branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.