Fix es_archiver rebuild_all action to support nested directories #27592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
review
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
|
CI should go green after #27608 is merged and master is pulled in |
spalger
approved these changes
Dec 20, 2018
|
@spalger just applied both changes, looks much better now 👍 |
💚 Build Succeeded |
spalger
approved these changes
Dec 20, 2018
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Dec 21, 2018
…stic#27592) * Fix es_archiver rebuild_all action to support nested directories * Merge two functions into one
mikecote
added a commit
that referenced
this pull request
Dec 21, 2018
) (#27676) * Fix es_archiver rebuild_all action to support nested directories * Merge two functions into one
mikecote
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running the following script currently fails
node scripts/es_archiver rebuild-all. It fails ontest/functional/fixtures/es_archiver/dashboardhaving sub folders.This PR changes the rebuild_all function to support nested directories.
Checklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers