New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Bump node to 6.16.0 #27921

Merged
merged 5 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@jbudz
Copy link
Contributor

jbudz commented Jan 2, 2019

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#6.16.0, notably adding support for the --max-http-header-size node option.

Closes #27724

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 2, 2019

@mistic

mistic approved these changes Jan 2, 2019

Copy link
Member

mistic left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 2, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Jan 2, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 2, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Jan 3, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 3, 2019

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Jan 3, 2019

retest

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Jan 3, 2019

Had to dig, it's legitimate, but not from this PR. 5.6 has been red on this test since December 19.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 3, 2019

jbudz added some commits Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 24, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@tylersmalley tylersmalley added the v5.6.15 label Feb 5, 2019

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Feb 5, 2019

@jbudz it seems like our upstream/5.6 is still failing into the CI tests

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Feb 5, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Feb 5, 2019

Quick recap: one test was disabled, it's failing both here and upstream. The test requires a response from an external service (maps manifest). I verified it's working locally.

@jbudz jbudz merged commit e4f1e8f into elastic:5.6 Feb 5, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment