Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tms without ems access #28111

Merged

Conversation

@aaronjcaldwell
Copy link
Contributor

commented Jan 4, 2019

Replaces the "fix" portions of #26500.

Resolves #26499, #22665 and partially #27832. The following behaviors are expected and were observed:

  • If TMS configured, use as the default
  • If no TMS configured, EMS used as default
  • If default (EMS or TMS) not available, load page quietly without error. Note: messaging for each of these will be an enhancement covered by a separate PR (#28114)
  • EMS given an 32 second timeout for response following internal discussion. This can be adjusted in the future if needed

2 unrelated (but map-related) issues were observed when merging in master:

When loading region maps, the following error was observed:

build_pipeline.ts:141 Uncaught (in promise) TypeError: Cannot read property 'join' of undefined at Object.region_map (build_pipeline.ts:141) at buildPipeline (build_pipeline.ts:191) at PipelineDataLoader.eval (pipeline_data_loader.ts:29) at step (tslib.js:129) at Object.eval [as next] (tslib.js:110) at eval (tslib.js:103) at new Promise (<anonymous>) at Object.__awaiter (tslib.js:99) at PipelineDataLoader.fetch (pipeline_data_loader.ts:26) at EmbeddedVisualizeHandler.fetch (embedded_visualize_handler.ts:382)

The kibana loading visualization appears to no longer be working, this issue is highlighted by this PR given the 8 second EMS fetch timeout, but again, appears unrelated.

I'll update this PR with links to each of the discovered issues.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

@aaronjcaldwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

jenkins, test this

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

@aaronjcaldwell aaronjcaldwell merged commit 837b00f into elastic:master Jan 7, 2019

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@aaronjcaldwell aaronjcaldwell removed the v6.5.5 label Jan 7, 2019

aaronjcaldwell added a commit to aaronjcaldwell/kibana that referenced this pull request Jan 7, 2019
Fix/tms without ems access (elastic#28111)
* Consolidate ems/tms request error handling, add timeout, ensure consistent return types

* Ensure tms is loaded (if configured), otherwise EMS. If neither is available, nothing is loaded

* Up time limit to 32 seconds
aaronjcaldwell added a commit to aaronjcaldwell/kibana that referenced this pull request Jan 7, 2019
Fix/tms without ems access (elastic#28111)
* Consolidate ems/tms request error handling, add timeout, ensure consistent return types

* Ensure tms is loaded (if configured), otherwise EMS. If neither is available, nothing is loaded

* Up time limit to 32 seconds
aaronjcaldwell added a commit that referenced this pull request Jan 7, 2019
Fix/tms without ems access (#28111) (#28180)
* Consolidate ems/tms request error handling, add timeout, ensure consistent return types

* Ensure tms is loaded (if configured), otherwise EMS. If neither is available, nothing is loaded

* Up time limit to 32 seconds
aaronjcaldwell added a commit that referenced this pull request Jan 7, 2019
Fix/tms without ems access (#28111) (#28179)
* Consolidate ems/tms request error handling, add timeout, ensure consistent return types

* Ensure tms is loaded (if configured), otherwise EMS. If neither is available, nothing is loaded

* Up time limit to 32 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.