Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use form label for Transaction type selector #28322

Merged

Conversation

@formgeist
Copy link
Contributor

commented Jan 9, 2019

Summary

Removes the inline copy for filtering by transaction type and uses the EuiFormRow label as a substitute.

screenshot 2019-01-09 at 10 24 09

Note: Couldn't not test IE11 due to #28091 - waiting for PR to be merged.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Use form label for type selector
Removes the inline copy for filtering by transaction type and uses the FormRow label as a substitute.

@formgeist formgeist added the Team:apm label Jan 9, 2019

@formgeist formgeist requested review from sqren and elastic/apm-ui Jan 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Pinging @elastic/apm-ui

@formgeist formgeist added the v7.0.0 label Jan 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

@sqren
sqren approved these changes Jan 9, 2019
Copy link
Member

left a comment

This adds additional vertical space but if designer is okay with it I'm too :)

@formgeist

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

@formgeist formgeist merged commit 6076d85 into elastic:master Jan 10, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
formgeist added a commit that referenced this pull request Jan 10, 2019
[APM] Use form label for Transaction type selector (#28322) (#28478)
* Use form label for type selector

Removes the inline copy for filtering by transaction type and uses the FormRow label as a substitute.

* [APM] Updated test snapshot

@formgeist formgeist deleted the formgeist:apm-formlabel-transaction-type-select branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.