Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use form label for Transaction type selector #28322

Merged
merged 2 commits into from Jan 10, 2019
Merged

[APM] Use form label for Transaction type selector #28322

merged 2 commits into from Jan 10, 2019

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Jan 9, 2019 •
edited

Summary

Removes the inline copy for filtering by transaction type and uses the EuiFormRow label as a substitute.

screenshot 2019-01-09 at 10 24 09

Note: Couldn't not test IE11 due to #28091 - waiting for PR to be merged.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@formgeist
Use form label for type selector
a1dfe67 
Removes the inline copy for filtering by transaction type and uses the FormRow label as a substitute.
@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Jan 9, 2019
@formgeist formgeist requested review from sorenlouv and a team January 9, 2019 10:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

sorenlouv
sorenlouv approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds additional vertical space but if designer is okay with it I'm too :)

@formgeist
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@formgeist formgeist merged commit 6076d85 into elastic:master Jan 10, 2019
@formgeist formgeist mentioned this pull request Jan 10, 2019
Merged
formgeist added a commit that referenced this pull request Jan 10, 2019
@formgeist
[APM] Use form label for Transaction type selector (#28322) (#28478)
cdbefd3 
* Use form label for type selector

Removes the inline copy for filtering by transaction type and uses the FormRow label as a substitute.

* [APM] Updated test snapshot
@formgeist formgeist deleted the apm-formlabel-transaction-type-select branch January 10, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@formgeist @elasticmachine @sorenlouv