Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gloablHeader/apps] use lastSubUrl when appropriate #28735

Merged
merged 2 commits into from Jan 15, 2019

Conversation

@spalger
Copy link
Member

commented Jan 15, 2019

When we added the k7 header we never brought over the lastSubUrl feature used to resume a previous state of an app that was left. This re-implements the feature by deep watching the navLinks (which are mutated directly in a number of locations) and re-emitting the list of navLinks they are updated.

The logic for when to render the navLink.lastSubUrl was taken from the current navigation.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

@joshdover
Copy link
Member

left a comment

LGTM, tested it out and everything works.

@spalger spalger merged commit ba30b72 into elastic:master Jan 15, 2019

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@spalger spalger deleted the spalger:fix/k7-apps-lastSubUrl branch Jan 15, 2019

kobelb added a commit to kobelb/kibana that referenced this pull request Jan 16, 2019
[gloablHeader/apps] use lastSubUrl when appropriate (elastic#28735)
When we added the k7 header we never brought over the `lastSubUrl` feature used to resume a previous state of an app that was left. This re-implements the feature by deep watching the navLinks (which are mutated directly in a number of locations) and re-emitting the list of navLinks they are updated.

The logic for when to render the `navLink.lastSubUrl` was taken [from the current navigation](https://github.com/elastic/kibana/blob/master/src/ui/public/chrome/directives/global_nav/app_switcher/app_switcher.html#L8).

@spalger spalger added the non-issue label Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.