Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`management/kibana/indices` => `management/kibana/index_patterns` #29151

Merged
merged 10 commits into from Jan 24, 2019

Conversation

@mattkime
Copy link
Contributor

commented Jan 23, 2019

Summary

The existing management ui uses indices and index for index pattern urls and code irregularly which is misleading.

  • (index|indices) => (index_pattern|index_patterns) in urls
  • rename angular directives
  • rename page object methods
  • rename the kibana management section

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mattkime mattkime added the WIP label Jan 23, 2019

@mattkime mattkime changed the title partial progress `management/kibana/indices` => `management/kibana/index_patterns` Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

mattkime added 3 commits Jan 23, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

mattkime added 2 commits Jan 23, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

@mattkime mattkime requested a review from cjcenizal Jan 24, 2019

@chrisdavies
Copy link
Contributor

left a comment

LGTM. I didn't pull down and test, but this looks like a reasonable changeset. I'm glad to see some work going into consistency issues!

@stacey-gammon

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

I think this is a breaking change because the URLs are changing... though I doubt anyone booked marked the indices pattern page. :) . But just to be safe, and since we are close anyway, I don't think this should be backported to 6.7. Otherwise, lgtm too (likewise didn't pull down and test), but great to see some clean up! 🎉

@mattkime mattkime merged commit f897026 into elastic:master Jan 24, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@mattkime mattkime added v7.0.0 and removed WIP labels Jan 24, 2019

@gchaps

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

@mattkime Could you please add this change to the Breaking Changes doc?

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.