Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xpack console specs #29506

Merged
merged 4 commits into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@bmcconaghy
Copy link
Contributor

commented Jan 29, 2019

This PR is the result of a rerunning of the spec to console tool against the latest elasticsearch master. While this looks like a lot of changes, it's all down to removal of _xpack namespace from api calls.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2019

Pinging @elastic/es-ui

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

I believe we'll only want these in 7.0+, ref elastic/elasticsearch#35958 (deprecation 7, removal 8)

@sebelga
Copy link
Contributor

left a comment

LGTM. Although do review my comment about the watcher where xpack still appears.

When I tested locally I can still see some _xpack prefix.

screen shot 2019-01-30 at 12 09 58

],
"documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-post-unfollow.html"
"documentation": "http://www.elastic.co/guide/en/elasticsearch/reference/current"

This comment has been minimized.

Copy link
@sebelga

sebelga Jan 30, 2019

Contributor

The scheme should probably stay https, no?

Edit: I see that many other documentation links have http, and there is a redirect from http to https so probably not that important.

This comment has been minimized.

Copy link
@bmcconaghy

bmcconaghy Jan 30, 2019

Author Contributor

these are generated, so it's all based on what is in the ES specs

@@ -1,10 +1,10 @@
{
"xpack.ml.put_filter": {
"ml.put_calendar": {

This comment has been minimized.

Copy link
@sebelga

sebelga Jan 30, 2019

Contributor

If this changes to put_calendar we might want to change the file name as well.

This comment has been minimized.

Copy link
@bmcconaghy

bmcconaghy Jan 30, 2019

Author Contributor

again, generated

@@ -5,8 +5,8 @@
"POST"
],
"patterns": [
"_xpack/watcher/watch/{watch_id}/_ack",

This comment has been minimized.

Copy link
@sebelga

sebelga Jan 30, 2019

Contributor

It seems that on this file and all the watcher files below, the xpack hasn't been removed from the id (xpack.watcher)

This comment has been minimized.

Copy link
@bmcconaghy

bmcconaghy Jan 30, 2019

Author Contributor

generated

@bmcconaghy bmcconaghy removed the v6.7.0 label Jan 30, 2019

@bmcconaghy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@sebelga fixed some issues, could you take another look? Any issues with generated files I'm just going to leave them as I don't want to edit generated files.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

@sebelga
Copy link
Contributor

left a comment

LGTM

@bmcconaghy bmcconaghy merged commit 779c9e1 into elastic:master Jan 31, 2019

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@bmcconaghy bmcconaghy deleted the bmcconaghy:update_xpack_console_specs branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.