Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add anomaly marker to charts when gap exists in data #29628

Merged

Conversation

@peteharverson
Copy link
Contributor

peteharverson commented Jan 30, 2019

Summary

Adds anomaly markers into the Single Metric Viewer (model plot disabled) and Anomaly Explorer charts where there is a gap in the source data. Fixes #22186 where previously no marker was plotted on the chart.

The anomaly is plotted with a y axis value corresponding to the actual value of the anomaly (likely to be 0).

Before:
image

After:
image

Checklist

For maintainers

Fixes #22186

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Jan 30, 2019

Pinging @elastic/ml-ui

Copy link
Member

jgowdyelastic left a comment

LGTM

Copy link
Contributor

alvarezmelissa87 left a comment

LGTM ⚡️

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Jan 30, 2019

Copy link
Contributor

walterra left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Jan 31, 2019

@peteharverson peteharverson merged commit 0467735 into elastic:master Jan 31, 2019
2 checks passed
2 checks passed
CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
@peteharverson peteharverson deleted the peteharverson:ml-chart-missing-data-anomaly branch Jan 31, 2019
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jan 31, 2019
)

* [ML] Add anomaly marker to charts when gap exists in data

* [ML] Amend check for anomaly markers on gaps and update Jest tests
peteharverson added a commit that referenced this pull request Jan 31, 2019
…29703)

* [ML] Add anomaly marker to charts when gap exists in data

* [ML] Amend check for anomaly markers on gaps and update Jest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.