New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin deprecations #29737

Merged
merged 5 commits into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@jbudz
Copy link
Contributor

jbudz commented Jan 31, 2019

  • When checking kibana settings we should expect the object to be unflattened before being passed to deprecations. Plugin prefixes that include dots should be translated to nested objects
  • deprecations/elasticsearch.hosts reuses the rename method for consistency between monitoring and core

Closes #28587

jbudz added some commits Jan 31, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 31, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 31, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 4, 2019

$ node scripts/kibana --xpack.monitoring.elasticsearch.ssl.ca=foo
  log   [18:54:56.871] [info][plugins-system] Starting [1] plugins: [testbed]
  log   [18:55:09.626] [warning][plugin] Skipping non-plugin directory at /mnt/c/elastic/kibana/src/legacy/core_plugins/ems_util
  log   [18:55:11.988] [warning][config][deprecation][xpack.monitoring] Config key "elasticsearch.ssl.ca" is deprecated. It has been replaced with "elasticsearch.ssl.certificateAuthorities"
node scripts/kibana --xpack.monitoring.elasticsearch.url=http://es:9200       
  log   [18:55:53.099] [info][plugins-system] Starting [1] plugins: [testbed]
  log   [18:56:05.784] [warning][plugin] Skipping non-plugin directory at /mnt/c/elastic/kibana/src/legacy/core_plugins/ems_util
  log   [18:56:08.117] [warning][config][deprecation][xpack.monitoring] Config key "elasticsearch.url" is deprecated. It has been replaced with "elasticsearch.hosts"
  log   [18:56:09.279] [info][optimize] Optimizing and caching bundles for graph, monitoring, space_selector, login, logout, logged_out, ml, dashboardViewer, apm, canvas, infra, kibana, stateSessionStorageRedirect, status_page and timelion. This may take a few minutes

@jbudz jbudz merged commit a0b806c into elastic:6.6 Feb 4, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

jbudz added a commit that referenced this pull request Feb 4, 2019

Fix plugin deprecations (#29737)
* [deprecations] convert flattened settings to nested settings

* [deprecations] reuse rename method for elasticsearch.url to elasticsearch.hosts

* newline

* add known issues to docs

jbudz added a commit to jbudz/kibana that referenced this pull request Feb 4, 2019

Fix plugin deprecations (elastic#29737)
* [deprecations] convert flattened settings to nested settings

* [deprecations] reuse rename method for elasticsearch.url to elasticsearch.hosts

* newline

* add known issues to docs
@cachedout

This comment has been minimized.

Copy link

cachedout commented Feb 5, 2019

jbudz added a commit that referenced this pull request Feb 6, 2019

Fix plugin deprecations (#29737) (#29985)
* [deprecations] convert flattened settings to nested settings

* [deprecations] reuse rename method for elasticsearch.url to elasticsearch.hosts

* newline

* add known issues to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment