New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for deleting old .tasks index #29774

Merged
merged 7 commits into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@joshdover
Copy link
Member

joshdover commented Jan 31, 2019

Summary

Fixes #29454

Because the .tasks is not currently reindex-able, this workaround allows the user to backup (via Console) and then delete the .tasks index (which will automatically get recreated) if the index was created before the current major version.

All code in this PR was intentionally made to be very specific to deleting this index and this index only. I want to eliminate any risk of a bug leading to accidentally deleting other user data.

To test this, you'll need to use this PR of Elasticsearch with a data directory that has a .tasks index from 5.x.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 31, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 31, 2019

@joshdover joshdover force-pushed the joshdover:reindex-tasks-index branch from 83c254b to c93def0 Feb 1, 2019

@joshdover joshdover requested a review from elastic/kibana-design as a code owner Feb 1, 2019

@joshdover joshdover changed the base branch from master to 6.x Feb 1, 2019

@joshdover joshdover force-pushed the joshdover:reindex-tasks-index branch from c93def0 to e6d2433 Feb 1, 2019

@joshdover joshdover changed the title [WIP] Add UI for deleting old .tasks index Add UI for deleting old .tasks index Feb 1, 2019

@joshdover joshdover added the review label Feb 1, 2019

joshdover added some commits Jan 31, 2019

@joshdover joshdover force-pushed the joshdover:reindex-tasks-index branch from e6d2433 to d26072c Feb 1, 2019

@joshdover joshdover requested a review from tylersmalley Feb 1, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 1, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

mattkime and others added some commits Jan 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

@joshdover joshdover force-pushed the joshdover:reindex-tasks-index branch from 447187c to 6018422 Feb 2, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 2, 2019

I don't think we need to port this to 7.0 as they should have a better solution for dealing with the tasks index by then.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

@joshdover joshdover merged commit 97037e3 into elastic:6.x Feb 2, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@joshdover joshdover deleted the joshdover:reindex-tasks-index branch Feb 2, 2019

@joshdover joshdover removed the v7.0.0 label Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment