Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a docker run example to Kibana Install doc #29911

Closed
wants to merge 5 commits into
base: 6.6
from

Conversation

Projects
None yet
5 participants
@pgoldtho
Copy link
Contributor

pgoldtho commented Feb 2, 2019

This makes the doc consistent with the Elasticsearch docker install page and would have saved me 30 minutes of head scratching

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Add a docker run example to Kibana Install doc
This makes the doc consistent with the Elasticsearch docker install page and would have saved me 30 minutes of head scratching
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 19, 2019

@pgoldtho the document goes into detail in regards to providing environment variable configuration. Was the part you were missing that docker run also accepts this configuration?

@mistic
Copy link
Member

mistic left a comment

@pgoldtho I think we can add this to the documentation. Just take in consideration the suggested changes as we have deprecated the option you used.

@tylersmalley maybe the info about the environment variables configuration is not enough to give the overall idea on how to use it, though this is general docker knowledge.

Show resolved Hide resolved docs/setup/docker.asciidoc Outdated
@pgoldtho

This comment has been minimized.

Copy link
Contributor Author

pgoldtho commented Feb 21, 2019

Updated the example. Note my Atom config also removed trailing spaces from some of the lines

@mistic
Copy link
Member

mistic left a comment

I just remember about some more useful changes 😃

Show resolved Hide resolved docs/setup/docker.asciidoc Outdated
@mistic
Copy link
Member

mistic left a comment

I left one last comment that I think we should take care of

Show resolved Hide resolved docs/setup/docker.asciidoc Outdated
@pgoldtho

This comment has been minimized.

Copy link
Contributor Author

pgoldtho commented Feb 28, 2019

I've updated the example as suggested. It looks like there is a pre-processor that substitutes values for {docker-repo} and {version}. Is it going to get confused by {elasticsearch-container-name-or-id}?

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Mar 1, 2019

@pgoldtho yeah maybe it is a better idea to replace it with for example docker run --link YOUR_ELASTICSEARCH_CONTAINER_NAME_OR_ID:elasticsearch -p 5601:5601 {docker-repo}:{version}

@mistic

mistic approved these changes Mar 5, 2019

Copy link
Member

mistic left a comment

LGTM

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Mar 5, 2019

@tylersmalley I think this is good to merge. What do u think?

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Mar 5, 2019

LGTM - thanks for working through this @mistic and @pgoldtho

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Mar 6, 2019

@pgoldtho I just realise you opened the PR against 6.6. Do you think you can open the exact same PR against master please? I'll approve it, merge it and take care of further backporting.

@pgoldtho

This comment has been minimized.

Copy link
Contributor Author

pgoldtho commented Mar 7, 2019

I'll see what I can do. I didn't create the PR directly. I clicked the Edit link on https://www.elastic.co/guide/en/kibana/current/docker.html

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Mar 7, 2019

pgoldtho added a commit to pgoldtho/kibana that referenced this pull request Mar 7, 2019

@pgoldtho pgoldtho referenced this pull request Mar 7, 2019

Merged

Add a docker run example to Kibana Install doc #32702

0 of 7 tasks complete
@pgoldtho

This comment has been minimized.

Copy link
Contributor Author

pgoldtho commented Mar 7, 2019

Done. See #32702

mistic added a commit that referenced this pull request Mar 11, 2019

Add a docker run example to Kibana Install doc2 (#32702)
* Add a docker run example to Kibana Install doc2 

See PR #29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>

mistic added a commit to mistic/kibana that referenced this pull request Mar 11, 2019

Add a docker run example to Kibana Install doc2 (elastic#32702)
* Add a docker run example to Kibana Install doc2 

See PR elastic#29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>

mistic added a commit to mistic/kibana that referenced this pull request Mar 11, 2019

Add a docker run example to Kibana Install doc2 (elastic#32702)
* Add a docker run example to Kibana Install doc2 

See PR elastic#29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>

mistic added a commit that referenced this pull request Mar 11, 2019

Add a docker run example to Kibana Install doc2 (#32702) (#32923)
* Add a docker run example to Kibana Install doc2 

See PR #29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>

mistic added a commit that referenced this pull request Mar 11, 2019

Add a docker run example to Kibana Install doc2 (#32702) (#32924)
* Add a docker run example to Kibana Install doc2 

See PR #29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.