New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] Add cancel button to reindexing #29913

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@joshdover
Copy link
Member

joshdover commented Feb 2, 2019

Summary

Related to #26368

Adds a "Cancel" button next to the reindex progress bar while the reindex task is running. Backend works by having the button click cancel the reindex task in ES, then when the worker polls the Tasks API and sees that it has been cancelled, it will do the remaining cleanup and set the status to cancelled.

screen shot 2019-02-04 at 4 26 54 pm

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@joshdover joshdover added the WIP label Feb 2, 2019

@joshdover joshdover requested a review from elastic/kibana-design as a code owner Feb 2, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 2, 2019

@cchaos
Copy link
Contributor

cchaos left a comment

Just scanned the code and had a couple suggestions.

@joshdover joshdover force-pushed the joshdover:reindex-cancel branch from fddeead to b5cb7d0 Feb 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 4, 2019

joshdover added some commits Feb 4, 2019

@joshdover joshdover force-pushed the joshdover:reindex-cancel branch from b5cb7d0 to 755d868 Feb 4, 2019

@joshdover joshdover changed the title [WIP] [upgrade] Add cancel button to reindexing [upgrade] Add cancel button to reindexing Feb 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 4, 2019

@joshdover joshdover added v6.7.0 and removed WIP labels Feb 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 4, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 5, 2019

retest

Updated with design changes

@joshdover

This comment has been minimized.

Copy link
Member Author

joshdover commented Feb 5, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@joshdover joshdover merged commit d166001 into elastic:master Feb 5, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@joshdover joshdover deleted the joshdover:reindex-cancel branch Feb 5, 2019

joshdover added a commit to joshdover/kibana that referenced this pull request Feb 5, 2019

joshdover added a commit that referenced this pull request Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment