Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings for saved object client #29951

Merged
merged 18 commits into from Feb 7, 2019
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 4, 2019

Summary

Add typings for the saved object client in the browser. @mikecote since that PR began before the reference changes, I had to merge them in, so it would be could if you could validate, that nothing broke there due to this PR.

For QA: This PR should not change any behavior, since it's a pure conversion from JavaScript to TypeScript.

This need to go to 7.0 still, since it's a requirement for TypeScriptification of the SavedObjectFinder, which is a requirement for the remaining EUIfication work, that should still go into 7.0.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added the WIP Work in progress label Feb 4, 2019
@epixa
Copy link
Member

epixa commented Feb 4, 2019

cc @mikecote

@timroes timroes changed the title [WIP] [skip ci] typings for saved object client Typings for saved object client Feb 5, 2019
@timroes
Copy link
Contributor Author

timroes commented Feb 5, 2019

Jenkins, test this

@timroes timroes added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@timroes timroes added v7.0.0 and removed WIP Work in progress labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for typing a critical piece of the Kibana infrastructure 🎉

Since I don't know this code very well I focused mainly on internal consistency. All in all it seems to work, but I left some inline comments below regarding imports from server-side code, some apparent left-overs from development and the usage of @ts-ignore directives.

src/ui/public/saved_objects/find_object_by_title.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/index.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.test.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.test.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.test.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.ts Outdated Show resolved Hide resolved
src/ui/public/saved_objects/saved_objects_client.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes timroes added the v8.0.0 label Feb 6, 2019
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming green CI 😉)

@timroes timroes added the v7.2.0 label Feb 6, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Feb 7, 2019

Jenkins, test this - flaky failure on dashboard embeddable test

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit fb2f056 into elastic:master Feb 7, 2019
@timroes timroes deleted the ts-saved-object-client branch February 7, 2019 11:43
timroes added a commit to timroes/kibana that referenced this pull request Feb 7, 2019
* WIP typings for saved object client

* Move more files to TS

* type saved objects client

* clean up typings for saved object client

* tie typings form server and client for saved objects together

* add missing html import typing to x-pack

* Add missing buildSourcePatterns

* Removed accidental comma

* add typings for saved_object_client tests and fix test cases

* duplicate case_conversion helpers for the moment

* Address PR review

* Fix some documentation

* Replace ts-ignore by any imports

* Remove expect.js from test

* Add more typings to prevent CI failure
timroes added a commit to timroes/kibana that referenced this pull request Feb 7, 2019
* WIP typings for saved object client

* Move more files to TS

* type saved objects client

* clean up typings for saved object client

* tie typings form server and client for saved objects together

* add missing html import typing to x-pack

* Add missing buildSourcePatterns

* Removed accidental comma

* add typings for saved_object_client tests and fix test cases

* duplicate case_conversion helpers for the moment

* Address PR review

* Fix some documentation

* Replace ts-ignore by any imports

* Remove expect.js from test

* Add more typings to prevent CI failure
timroes added a commit that referenced this pull request Feb 7, 2019
* WIP typings for saved object client

* Move more files to TS

* type saved objects client

* clean up typings for saved object client

* tie typings form server and client for saved objects together

* add missing html import typing to x-pack

* Add missing buildSourcePatterns

* Removed accidental comma

* add typings for saved_object_client tests and fix test cases

* duplicate case_conversion helpers for the moment

* Address PR review

* Fix some documentation

* Replace ts-ignore by any imports

* Remove expect.js from test

* Add more typings to prevent CI failure
timroes added a commit that referenced this pull request Feb 7, 2019
* WIP typings for saved object client

* Move more files to TS

* type saved objects client

* clean up typings for saved object client

* tie typings form server and client for saved objects together

* add missing html import typing to x-pack

* Add missing buildSourcePatterns

* Removed accidental comma

* add typings for saved_object_client tests and fix test cases

* duplicate case_conversion helpers for the moment

* Address PR review

* Fix some documentation

* Replace ts-ignore by any imports

* Remove expect.js from test

* Add more typings to prevent CI failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants