New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin deprecations (#29737) #29985

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@jbudz
Copy link
Contributor

jbudz commented Feb 4, 2019

Forward port of #29737

  • When checking kibana settings we should expect the object to be unflattened before being passed to deprecations. Plugin prefixes that include dots should be translated to nested objects
  • deprecations/elasticsearch.hosts reuses the rename method for consistency between monitoring and core

Closes #28587

Fix plugin deprecations (#29737)
* [deprecations] convert flattened settings to nested settings

* [deprecations] reuse rename method for elasticsearch.url to elasticsearch.hosts

* newline

* add known issues to docs

@jbudz jbudz self-assigned this Feb 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 4, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Feb 4, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 4, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@jbudz jbudz merged commit f60e17d into elastic:master Feb 6, 2019

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment