Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Copy Post URL: track layoutID in state #30029

Merged

Conversation

@tsullivan
Copy link
Contributor

tsullivan commented Feb 5, 2019

Fix #30010

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 5, 2019

tsullivan added 2 commits Feb 5, 2019
@tsullivan tsullivan force-pushed the tsullivan:fix/reporting-layout-mode-switch branch from fc0ea4f to 5be90ab Feb 5, 2019
This reverts commit b2e5f60.
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 5, 2019

@joelgriffith

This comment has been minimized.

Copy link
Contributor

joelgriffith commented Feb 5, 2019

Do you think it'd be helpful to "export" or show the URL that reporting uses to generate the PDF in the reporting panel?

@tsullivan

This comment has been minimized.

Copy link
Contributor Author

tsullivan commented Feb 5, 2019

Do you think it'd be helpful to "export" or show the URL that reporting uses to generate the PDF in the reporting panel?

Actually not for now.

We've been talking about changing up the APIs to make them more expressive (not sure if that's the right word) or allow the user to see and control the params better. When we have that, we will need to show the URL string or POST params (I think the API will need to support having no post body, like today). For now, I think it's too early though.

@tsullivan tsullivan merged commit ef0fba1 into elastic:master Feb 5, 2019
2 checks passed
2 checks passed
CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
@tsullivan tsullivan deleted the tsullivan:fix/reporting-layout-mode-switch branch Feb 5, 2019
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 5, 2019
* [Reporting] Post URL: track layoutID in state

* I think this code was not supposed to be here

* ts fix

* revert some diff

* Revert "I think this code was not supposed to be here"

This reverts commit b2e5f60.

* static getAbsoluteReportGenerationUrl

* ts fix
@tsullivan

This comment has been minimized.

Copy link
Contributor Author

tsullivan commented Feb 5, 2019

6.x/6.7.0: #30137

tsullivan added a commit that referenced this pull request Feb 5, 2019
* [Reporting] Post URL: track layoutID in state

* I think this code was not supposed to be here

* ts fix

* revert some diff

* Revert "I think this code was not supposed to be here"

This reverts commit b2e5f60.

* static getAbsoluteReportGenerationUrl

* ts fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.