New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] Handle APM being disabled #30308

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@joshdover
Copy link
Member

joshdover commented Feb 6, 2019

Summary

Fixes #30301 by handling the situation when the APM plugin is disabled. Updated the types to also reflect that the plugin is optional on the Plugins interface.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 6, 2019

@joshdover joshdover requested a review from tylersmalley Feb 6, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

Tested, LGTM!

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 6, 2019

@joshdover joshdover force-pushed the joshdover:fix/issue-30301 branch from cb61c53 to 97693c0 Feb 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 7, 2019

@joshdover joshdover merged commit b5fdda4 into elastic:7.x Feb 7, 2019

1 check passed

kibana-ci Build finished.
Details

@joshdover joshdover deleted the joshdover:fix/issue-30301 branch Feb 7, 2019

joshdover added a commit to joshdover/kibana that referenced this pull request Feb 7, 2019

joshdover added a commit that referenced this pull request Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment