New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tslint] ban exclusive tests #30448

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@spalger
Copy link
Member

spalger commented Feb 7, 2019

Fixes #30262

Adds tslint rules to explicitly ban describe.only, it.only, and test.only.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 7, 2019

@spalger spalger added v7.1.0 and removed v7.0.1 labels Feb 7, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

Nice, LGTM

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 8, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 8, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 8, 2019

@spalger spalger merged commit 3f5597a into elastic:master Feb 8, 2019

1 check passed

kibana-ci Build finished.
Details

spalger added a commit to spalger/kibana that referenced this pull request Feb 8, 2019

[tslint] ban exclusive tests (elastic#30448)
Fixes elastic#30262

Adds tslint rules to explicitly ban `describe.only`, `it.only`, and `test.only`.

spalger added a commit to spalger/kibana that referenced this pull request Feb 8, 2019

[tslint] ban exclusive tests (elastic#30448)
Fixes elastic#30262

Adds tslint rules to explicitly ban `describe.only`, `it.only`, and `test.only`.

spalger added a commit that referenced this pull request Feb 8, 2019

[tslint] ban exclusive tests (#30448) (#30464)
Fixes #30262

Adds tslint rules to explicitly ban `describe.only`, `it.only`, and `test.only`.

lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Feb 8, 2019

[tslint] ban exclusive tests (elastic#30448)
Fixes elastic#30262

Adds tslint rules to explicitly ban `describe.only`, `it.only`, and `test.only`.

spalger added a commit that referenced this pull request Feb 10, 2019

[tslint] ban exclusive tests (#30448) (#30462)
Fixes #30262

Adds tslint rules to explicitly ban `describe.only`, `it.only`, and `test.only`.
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Feb 10, 2019

7.x/7.1: 76dc029
7.0: d8359dc

@spalger spalger deleted the spalger:tslint/ban-exclusive-tests branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment