New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x][ci] update source/snapshot branch check #30548

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
5 participants
@jbudz
Copy link
Contributor

jbudz commented Feb 8, 2019

On release branches, we typically want to use snapshot builds to save time. On other branches we typically want to build from source to get latest changes.

The check here is looking for master, but now that we've branched it needs to be updated to 7.x.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 8, 2019

@mistic

mistic approved these changes Feb 8, 2019

Copy link
Member

mistic left a comment

LGTM

@epixa

This comment has been minimized.

Copy link
Member

epixa commented Feb 8, 2019

We may have other failures still, so if CI gets past this part of the build, go ahead and merge.

@epixa epixa added the :CI label Feb 8, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 8, 2019

The downside to this change is the snapshot will not be part of the packer cache. In order to do that, master would need to know about the next versions for 7.0.x and 7.x.x, which isn't maintainable. Though, with the CDN changes, this should be much faster than building from source.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 8, 2019

@jbudz jbudz merged commit 962acc4 into elastic:7.x Feb 8, 2019

1 check failed

kibana-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment