New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.7] Allow for compatibility with ES 7.x #30614

Closed
wants to merge 1 commit into
base: 6.7
from

Conversation

Projects
None yet
4 participants
@tylersmalley
Copy link
Member

tylersmalley commented Feb 11, 2019

During an upgrade to 7.0, ES is upgraded first so Kibana needs to be compatible with ES 7.0. For this, we must set include_type_name on the mapping requests.

Closes #30293

[6.7] Allow for compatibility with ES 7.x
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 11, 2019

@@ -52,7 +52,7 @@ export interface FullIndexInfo {
* index mappings are somewhat what we expect.
*/
export async function fetchInfo(callCluster: CallCluster, index: string): Promise<FullIndexInfo> {
const result = await callCluster('indices.get', { ignore: [404], index });
const result = await callCluster('indices.get', { ignore: [404], index, includeTypeName: true });

This comment has been minimized.

@chrisdavies

chrisdavies Feb 11, 2019

Contributor

I think these need to be include_type_name and they need to be added to the type defs... I'll do it.

@@ -93,7 +93,7 @@ export function importDataProvider(callWithRequest) {
body.settings = settings;
}

await callWithRequest('indices.create', { index, body });
await callWithRequest('indices.create', { index, body, includeTypeName: true });

This comment has been minimized.

@peteharverson

peteharverson Feb 11, 2019

Contributor

I think includeTypeName (or is it include_type_name?) needs to be added to the settings in the indexData function a few lines below this.

@tylersmalley

This comment has been minimized.

Copy link
Member Author

tylersmalley commented Feb 11, 2019

Closing in favor of #30636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment