Kill unnecessary re-renders in ElementWrapper by clintandrewhall · Pull Request #31734 · elastic/kibana

clintandrewhall · 2019-02-21T20:00:00Z

Summary (fixes #29700)

This is a small change that creates a huge impact on UI performance in Canvas.

As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React.

In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel.

By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad.

Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element):

Here is a snapshot after. That reconciliation now completes in 50ms or less:

This is not the end of this problem. There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-02-21T20:00:03Z

Pinging @elastic/kibana-canvas

elasticmachine · 2019-02-21T20:15:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-21T20:57:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

monfera

LGTM, great change!

There's some minor yarn.lock conflicts due to earlier merges.

Apparently unrelated to this PR or your preceding PR (EventEmitters leak), but I saw this just now, after doing some crazyman drag&drop testing (15-20 shapes and one uploaded image being dragged and dropped prolifically): <= @w33ble just told me this warning has been around for a while when an image is present, so pls. ignore this from the angle of this PR

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in withState(withState(lifecycle(Connect(branch(ArgFormComponent))))) (created by withState(withState(withState(lifecycle(Connect(branch(ArgFormComponent)))))))
    in withState(withState(withState(lifecycle(Connect(branch(ArgFormComponent)))))) (created by FunctionFormComponent)
    in div (created by EuiPanel)
    in EuiPanel (created by SidebarSection)
    in SidebarSection (created by FunctionFormComponent)
    in div (created by FunctionFormComponent)
    in FunctionFormComponent (created by branch(FunctionFormComponent))
    in branch(FunctionFormComponent) (created by branch(branch(FunctionFormComponent)))
    in branch(branch(FunctionFormComponent)) (created by branch(branch(branch(FunctionFormComponent))))
    in branch(branch(branch(FunctionFormComponent))) (created by Connect(branch(branch(branch(FunctionFormComponent)))))
    in Connect(branch(branch(branch(FunctionFormComponent)))) (created by FunctionFormList)

w33ble · 2019-02-22T22:55:35Z

FYI, when I try to merge master and bootstrap to fix the yarn conflict, I get a build error on some types in the i18n package. No idea what's up with that, but the conflict might be tricky to fix because of it...

monfera · 2019-02-22T23:14:22Z

Wondering how it can happen as this PR seems to have no i18n aspect on a superficial look. Maybe rebasing it on current master would fix whatever glitch is preventing it. Btw. I saw it in full green (no merge conflict, and CI passed), no idea if me merging Clint's other PR caused the merge conflict or build issue, or something unrelated that went in during that approx. one hour (other folks merged to master too).

w33ble · 2019-02-22T23:18:57Z

Can confirm that the re-renders on mouse move is no longer an issue. There's still seemingly still a lot of re-renders happening when you move things around, but this is an awesome start!

w33ble

One question, but this looks good. The app seems to load a big faster, and interactions seem smoother too. I'm not sure how much of that is placebo, but I'll take it 😉.

I was hoping that this might fix #25070, but no dice, it's still really laggy. All the same, this is a win.

   __    ___  _____           _ 
  / /   / _ \/__   \/\/\     / \
 / /   / /_\/  / /\/    \   /  /
/ /___/ /_\\  / / / /\/\ \ /\_/ 
\____/\____/  \/  \/    \/ \/

w33ble · 2019-02-22T23:22:27Z

    "ts-loader": "^5.2.2",
    "typescript": "^3.0.3",
    "vinyl-fs": "^3.0.2",
+    "why-did-you-update": "^1.0.6",


Do we need this in the package? You're not using it anywhere, and it seems easy enough to only pull it in locally when you want to diagnose re-renders.

monfera · 2019-02-23T18:55:25Z

@clintandrewhall @w33ble since it's a personal feature branch, I can't push a commit to it (I contemplated merging it haha), but here's what I did:

Remove why-did-you-update from package.json (though it's a devDependency and seems useful enough to have it around)
Restore yarn.lock to what it was before - the yarn.lock diff in this PR has all kinds of version number differences
Rebase on current master - might not be necessary
Run yarn kbn bootstrap, it completes nicely and yarn.lock is good

monfera · 2019-02-23T20:50:39Z

... looks like we have this perf enhancement opportunity in 24 other components that use connect in Canvas and maybe more that don't - as you said, the real solution is flattening out state and props to more closely tie viewModels to views and I guess to avoid somewhat expensive equality checks

w33ble · 2019-02-25T16:50:03Z

Most of the connect use probably isn't an issue, but where it is, or where the selector is the issue (as in this PR), I agree, there's big opportunity for performance gains.

clintandrewhall · 2019-02-25T16:54:28Z

I'm already investigating more improvements... I'll keep shipping them as I find them! See #31779.

elasticmachine · 2019-02-25T21:06:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

@monfera

## Summary (fixes elastic#29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

@monfera

## Summary (fixes elastic#29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

@monfera

## Summary (fixes elastic#29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

@monfera

## Summary (fixes #29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

@monfera

## Summary (fixes #29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

Backports the following commits to 6.7: - Kill unnecessary re-renders in ElementWrapper (#31734)

@monfera

## Summary (fixes elastic#29700) This is a small change that creates a huge impact on UI performance in Canvas. As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change. These changes in state were causing every active Element to re-render in React. In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes. This would happen even if the mouse were moved a single pixel. By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread. This performance impact intensifies as one adds Elements to the workpad. Here is a performance shapshot before this change was made. Notice the React tree reconciliation encompasses the entire 280ms. This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element): ![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png) Here is a snapshot after. That reconciliation now completes in 50ms or less: ![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png) *This is not the end of this problem.* There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place. @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ - [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) - [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

Fix unnecessary re-renders in ElementWrapper

e0e91e7

clintandrewhall added v7.0.0 performance Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.7.0 labels Feb 21, 2019

clintandrewhall requested review from cqliu1, monfera and w33ble February 21, 2019 20:00

clintandrewhall requested a review from a team as a code owner February 21, 2019 20:00

Fix yarn.lock

678b029

monfera approved these changes Feb 22, 2019

View reviewed changes

w33ble added v8.0.0 v7.2.0 labels Feb 22, 2019

w33ble approved these changes Feb 22, 2019

View reviewed changes

w33ble mentioned this pull request Feb 22, 2019

Huge lag renaming workpad #25070

Closed

clintandrewhall added 2 commits February 25, 2019 14:23

Fix yarn.lock; remove dev dependency

744ea6d

Merge branch 'master' into element-wrapper-perf

4cd04be

clintandrewhall merged commit dd633a3 into elastic:master Feb 25, 2019

clintandrewhall mentioned this pull request Feb 25, 2019

[7.x] Kill unnecessary re-renders in ElementWrapper (#31734) #31966

Merged

clintandrewhall mentioned this pull request Feb 25, 2019

[7.0] Kill unnecessary re-renders in ElementWrapper (#31734) #31967

Merged

clintandrewhall mentioned this pull request Feb 25, 2019

[6.7] Kill unnecessary re-renders in ElementWrapper (#31734) #31969

Merged

clintandrewhall added a commit that referenced this pull request Feb 26, 2019

[6.7] Kill unnecessary re-renders in ElementWrapper (#31734) (#31969)

bc7ff50

Backports the following commits to 6.7: - Kill unnecessary re-renders in ElementWrapper (#31734)

w33ble mentioned this pull request Mar 20, 2019

Slow initial loading of application #27352

Closed

w33ble mentioned this pull request Mar 28, 2019

Fix: recreate handlers and reset completed state on expression change #33900

Merged

5 tasks

clintandrewhall deleted the element-wrapper-perf branch June 6, 2019 04:24

Uh oh!

Conversation

clintandrewhall commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary (fixes #29700)

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 21, 2019

Uh oh!

elasticmachine commented Feb 21, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Feb 21, 2019

💚 Build Succeeded

Uh oh!

monfera left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

w33ble commented Feb 22, 2019

Uh oh!

monfera commented Feb 22, 2019

Uh oh!

w33ble commented Feb 22, 2019

Uh oh!

w33ble left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

w33ble Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

monfera commented Feb 23, 2019

Uh oh!

monfera commented Feb 23, 2019

Uh oh!

w33ble commented Feb 25, 2019

Uh oh!

clintandrewhall commented Feb 25, 2019

Uh oh!

elasticmachine commented Feb 25, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

clintandrewhall commented Feb 21, 2019 •

edited

Loading

monfera left a comment •

edited

Loading

w33ble left a comment •

edited

Loading