Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when migration not defined in same plugin as mappings #31739

Merged
merged 4 commits into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@mikecote
Copy link
Contributor

mikecote commented Feb 21, 2019

Fixes #31694.

This PR makes the system throw an error when a plugin defines a migration but doesn't define/own the mappings. This is to enforce migrations to be defined in the same plugin that defines the mappings.

@mikecote mikecote self-assigned this Feb 21, 2019

@mikecote mikecote requested a review from tylersmalley Feb 21, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 21, 2019

@mikecote mikecote added the review label Feb 21, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Feb 21, 2019

@mikecote mikecote requested a review from elastic/kibana-operations Feb 25, 2019

mikecote added some commits Feb 26, 2019

@mikecote mikecote requested review from spalger Feb 26, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Feb 26, 2019

@spalger
Copy link
Member

spalger left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 4, 2019

@mikecote mikecote merged commit d4488d6 into elastic:master Mar 4, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

mikecote added a commit to mikecote/kibana that referenced this pull request Mar 4, 2019

Throw error when migration not defined in same plugin as mappings (el…
…astic#31739)

* Throw error when migration not defined in same plugin as mappings

* Apply PR feedback

mikecote added a commit that referenced this pull request Mar 4, 2019

Throw error when migration not defined in same plugin as mappings (#3…
…1739) (#32411)

* Throw error when migration not defined in same plugin as mappings

* Apply PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.