Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clearing number of replicas from existing policy #31905

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@bmcconaghy
Copy link
Contributor

commented Feb 25, 2019

Resolves #31443

This change fixes a bug where the user couldn't clear out the number of replicas from an ILM policy once they were defined for a phase. To test, create an ILM policy with the Number of Replicas set for a phase, then edit it and clear that value out and save. The field should be empty when you edit it again.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

Pinging @elastic/es-ui

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

@sebelga
Copy link
Contributor

left a comment

Tested locally and LGTM!

@bmcconaghy bmcconaghy merged commit ae72315 into elastic:master Feb 25, 2019

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@bmcconaghy bmcconaghy deleted the bmcconaghy:fix_clear_num_replicas_ilm branch Feb 25, 2019

bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019

bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019

bmcconaghy added a commit that referenced this pull request Feb 25, 2019

bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019

bmcconaghy added a commit that referenced this pull request Feb 25, 2019

bmcconaghy added a commit that referenced this pull request Feb 25, 2019

alakahakai added a commit to alakahakai/kibana that referenced this pull request Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.