Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Usability: larger minimum element size #32106

Merged
merged 1 commit into from Feb 27, 2019
Merged

Conversation

@monfera
Copy link
Member

monfera commented Feb 27, 2019

Closes #32073 - thanks Catherine for the report!

Minimum element size used to be zero, but this currently makes it impossible to select elements shrunk to the minimum size.

minsize
(Separate issue filed for disappearing shape paint on vertical resize)

It'll still be possible for elements to be very small if resized so, but at least it can be corrected or deleted without having to resort to undo. Also, elements that are transparent or of identical color to the background when minimally sized will obviously be invisible. The real solution to that would be:

  1. Keyboard cycling through the elements (see also this)
  2. Viewing the list of elements on a side panel, preferably as part of a layers implementation
@monfera monfera self-assigned this Feb 27, 2019
@monfera monfera requested a review from cqliu1 Feb 27, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 27, 2019

@monfera monfera requested a review from elastic/kibana-canvas as a code owner Feb 27, 2019
@monfera monfera changed the title Usability: larger minimum element size [Canvas] Usability: larger minimum element size Feb 27, 2019
@monfera monfera added the review label Feb 27, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 27, 2019

@monfera

This comment has been minimized.

Copy link
Member Author

monfera commented Feb 27, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 27, 2019

@cqliu1
cqliu1 approved these changes Feb 27, 2019
Copy link
Contributor

cqliu1 left a comment

LGTM 👍

@cqliu1 cqliu1 added the v8.0.0 label Feb 27, 2019
@monfera monfera merged commit 0530dfb into master Feb 27, 2019
2 checks passed
2 checks passed
CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details
monfera added a commit to monfera/kibana that referenced this pull request Feb 27, 2019
monfera added a commit to monfera/kibana that referenced this pull request Feb 27, 2019
monfera added a commit to monfera/kibana that referenced this pull request Feb 27, 2019
monfera added a commit that referenced this pull request Feb 27, 2019
monfera added a commit that referenced this pull request Feb 27, 2019
monfera added a commit that referenced this pull request Feb 27, 2019
@monfera monfera deleted the larger-minimum-element-size branch Feb 27, 2019
alakahakai added a commit to alakahakai/kibana that referenced this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.