Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KQL handling of carriage return #32150

Merged
merged 1 commit into from Feb 28, 2019

Conversation

lukasolson
Copy link
Member

Looks like a typo made it into the KQL grammar resulting in carriage returns (\r) being returned as tab characters. This PR fixes this.

@lukasolson lukasolson added v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:KQL KQL v8.0.0 v7.2.0 v6.7.1 labels Feb 27, 2019
@lukasolson lukasolson self-assigned this Feb 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasolson lukasolson merged commit 23fe22c into elastic:master Feb 28, 2019
lukasolson added a commit to lukasolson/kibana that referenced this pull request Feb 28, 2019
lukasolson added a commit to lukasolson/kibana that referenced this pull request Feb 28, 2019
lukasolson added a commit to lukasolson/kibana that referenced this pull request Feb 28, 2019
@lukasolson
Copy link
Member Author

7.x (7.1.0): a8dde3e
7.0 (7.0.0): e006f63
6.7 (6.7.1): f021fa7

@lukasolson lukasolson deleted the fixKqlCarriageReturn branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:KQL KQL Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.7.1 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants