Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Bump node to 6.17.0 #32201

Merged
merged 3 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@jbudz
Copy link
Contributor

commented Feb 28, 2019

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#6.17.0

Relevant changes:

http: Backport server.keepAliveTimeout
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 28, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 28, 2019

@jbudz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

This is a sneaky update.

server.listener.keepAliveTimeout = 120e3;
needs to be backported

tylersmalley and others added some commits Jun 11, 2018

Resolve intermittent premature connection closed (#19808)
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
6
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

@mistic

mistic approved these changes Mar 7, 2019

Copy link
Member

left a comment

LGTM

@jbudz jbudz merged commit e4c8b3e into elastic:5.6 Mar 8, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.