Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/run] typescriptify the dev/run helper #32705

Merged
merged 4 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@spalger
Copy link
Member

spalger commented Mar 7, 2019

Simple typescript conversion of the src/dev/run helpers.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 7, 2019

spalger added some commits Mar 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 7, 2019

@spalger spalger force-pushed the spalger:tsify/dev-run-helper branch from 88ab98c to 115e47e Mar 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 8, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 8, 2019

@spalger spalger requested a review from azasypkin Mar 8, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM

@spalger spalger merged commit a854a11 into elastic:master Mar 8, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[dev/run] typescriptify the dev/run helper (elastic#32705)
Simple typescript conversion of the `src/dev/run` helpers.

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[dev/run] typescriptify the dev/run helper (elastic#32705)
Simple typescript conversion of the `src/dev/run` helpers.

spalger added a commit that referenced this pull request Mar 8, 2019

[dev/run] typescriptify the dev/run helper (#32705) (#32734)
Simple typescript conversion of the `src/dev/run` helpers.

spalger added a commit that referenced this pull request Mar 8, 2019

[dev/run] typescriptify the dev/run helper (#32705) (#32735)
Simple typescript conversion of the `src/dev/run` helpers.
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Mar 8, 2019

7.x/7.1: 1b30637
7.0: 87170fd

@spalger spalger deleted the spalger:tsify/dev-run-helper branch Mar 8, 2019

spalger added a commit that referenced this pull request Mar 8, 2019

[ts] add script to verify that all ts is in a project (#32727)
Based on #32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[ts] add script to verify that all ts is in a project (elastic#32727)
Based on elastic#32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[ts] add script to verify that all ts is in a project (elastic#32727)
Based on elastic#32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

@spalger spalger added the v6.7.0 label Mar 8, 2019

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[dev/run] typescriptify the dev/run helper (elastic#32705)
Simple typescript conversion of the `src/dev/run` helpers.

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[ts] add script to verify that all ts is in a project (elastic#32727)
Based on elastic#32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Mar 8, 2019

backport for 6.7 included in #32828

spalger added a commit that referenced this pull request Mar 9, 2019

[7.0] [ts] add script to verify that all ts is in a project (#32727) (#…
…32827)

* [ts] add script to verify that all ts is in a project (#32727)

Based on #32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

* tests typescript migration (#31234)

* add typescript support for functional tests

* [ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files (#31948)

In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.
# Conflicts:
#	src/functional_test_runner/lib/config/schema.js
#	test/common/services/es.ts
#	test/functional/page_objects/index.ts
#	test/functional/services/apps_menu.js
#	yarn.lock

spalger added a commit that referenced this pull request Mar 9, 2019

[6.7] [ts] add script to verify that all ts is in a project (#32727) (#…
…32828)

* [dev/run] typescriptify the dev/run helper (#32705)

Simple typescript conversion of the `src/dev/run` helpers.

* [ts] add script to verify that all ts is in a project (#32727)

Based on #32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.

* select all ts files from tsconfig.json file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.