Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] derive bootstrap cache path from base branch, make optional #32793

Merged
merged 4 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@spalger
Copy link
Member

spalger commented Mar 8, 2019

Rather than hard coding the bootstrap cache to master.tar, and leading to issues like #32782 when new versions are branched from master, this updated the extract_bootstrap_cache script to look for a cache using the targetBranch name. Additionally, we will simply log a big warning when the packer cache is missing, rather than throwing an error. I'm working now on building unique bootstrap caches for each base branch.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 8, 2019

@mistic

mistic approved these changes Mar 8, 2019

Copy link
Member

mistic left a comment

LGTM

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Mar 8, 2019

@spalger spalger force-pushed the spalger:ci/make-bootstrap-cache-optional branch from 797f2f9 to a3b9268 Mar 8, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 8, 2019

@spalger spalger merged commit 441c3dd into elastic:master Mar 8, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

spalger added a commit to spalger/kibana that referenced this pull request Mar 8, 2019

[ci] derive bootstrap cache path from base branch, make optional (ela…
…stic#32793)

* [ci] derive bootstrap cache path from base branch, make optional

* describe the path we're looking for in warning

* use PR_TARGET_BRANCH, not PR_SOURCE_BRANCH

spalger added a commit that referenced this pull request Mar 8, 2019

[7.x] [ci] derive bootstrap cache path from base branch, make optional (
#32793) (#32811)

Backports the following commits to 7.x:
 - [ci] derive bootstrap cache path from base branch, make optional  (#32793)
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Mar 8, 2019

7.x: 289ddf6

@spalger spalger deleted the spalger:ci/make-bootstrap-cache-optional branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.