Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.7] [types removal] The parameter include_type_name should be explicitly specified in get indices requests to prepare for 7.0. #32891

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
6 participants
@alexwizp
Copy link
Contributor

alexwizp commented Mar 11, 2019

Summary

[types removal] The parameter include_type_name should be explicitly specified in get indices requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions."

Request

image

Checklist

For maintainers

[types removal] The parameter include_type_name should be explicitly …
…specified in get indices requests to prepare for 7.0. In 7.0 include_type_name will default to 'false', which means responses will omit the type name in mapping definitions."
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 11, 2019

@jakelandis
Copy link
Contributor

jakelandis left a comment

LGTM

@nreese

nreese approved these changes Mar 11, 2019

Copy link
Contributor

nreese left a comment

lgtm
code review, tested changes in 6.7 with chrome

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 11, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM - it's odd that indices.exists would have the depreciation since it doesn't specify or return mapping types. In 6.7, we have mostly been setting include_type_name to true, to handle the case when we upgrade to 7.0, however, since this doesn't touch mapping types it will have the added benefit of not introducing deprecations during a rolling upgrade to 7.0

@alexwizp alexwizp merged commit db9b734 into elastic:6.7 Mar 11, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.