Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated field [valueType] used, expected [value_type] instead #32985

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@alexwizp
Copy link
Contributor

alexwizp commented Mar 12, 2019

Summary

Deprecated field [valueType] used, expected [value_type] instead

Request

image

Checklist

For maintainers

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@alexwizp alexwizp force-pushed the alexwizp:valueType branch from 3160e94 to 4e2b1ab Mar 12, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@nreese

This comment has been minimized.

Copy link
Contributor

nreese commented Mar 12, 2019

@alexwizp

This comment has been minimized.

Copy link
Contributor Author

alexwizp commented Mar 12, 2019

@nreese about this argument you can read here: https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations.html

src/legacy/ui/public/agg_types/buckets/terms.js I don't understand your question. It's already in my PR see: https://github.com/elastic/kibana/pull/32985/files

@jakelandis

This comment has been minimized.

Copy link
Contributor

jakelandis commented Mar 12, 2019

@polyfractal - I am not familiar with this deprecation, can you take a quick look and ensure that this is a safe change (going to 7.0.0). I think it is, just wanted someone with more familiarity.

@polyfractal

This comment has been minimized.

Copy link
Member

polyfractal commented Mar 12, 2019

Should be safe to switch in 7.0.0, I dug through the history and valueType was deprecated in 5.2.0. We should probably remove it on the ES side at this point...

Just a note: value_type is designed for scripted aggs or unmapped fields, since in both of those cases we don't know what the "intended" data type is. I see that one of the usages is with a script, but the other usage appears to just be a blanket coverage for any numeric terms agg (converting to float). There might be a reason for that with how Kibana works, but it is a little unusual usage so I wanted to flag it.

@alexwizp

This comment has been minimized.

Copy link
Contributor Author

alexwizp commented Mar 12, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@alexwizp

This comment has been minimized.

Copy link
Contributor Author

alexwizp commented Mar 13, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@alexwizp alexwizp force-pushed the alexwizp:valueType branch from 4e2b1ab to dc6b405 Mar 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@jakelandis
Copy link
Contributor

jakelandis left a comment

LGTM

@alexwizp

This comment has been minimized.

Copy link
Contributor Author

alexwizp commented Mar 14, 2019

@nreese @tylersmalley please have a look

@alexwizp alexwizp merged commit e7837af into elastic:master Mar 15, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

alexwizp added a commit that referenced this pull request Mar 15, 2019

alexwizp added a commit that referenced this pull request Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.