Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.6] [ci] build es from source until snapshots support 6.6.3 #33033

Closed
wants to merge 2 commits into
base: 6.6
from

Conversation

Projects
None yet
3 participants
@spalger
Copy link
Member

spalger commented Mar 12, 2019

Based on #33036

Until we have 6.6.3 snapshots, we should build from source on CI.

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Mar 12, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Mar 12, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

elasticmachine commented Mar 12, 2019

@spalger spalger force-pushed the spalger:ci/6.6/es-from-source branch 2 times, most recently from fba84c1 to fc4a155 Mar 12, 2019

spalger added some commits Mar 13, 2019

@spalger spalger force-pushed the spalger:ci/6.6/es-from-source branch from fc4a155 to 7f12f00 Mar 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@spalger spalger added the blocked label Mar 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@@ -22,6 +22,14 @@ import { createAbsolutePathSerializer } from '@kbn/dev-utils';

expect.addSnapshotSerializer(createAbsolutePathSerializer(process.cwd()));

const INITIAL_TEST_ES_FROM = process.env.TEST_ES_FROM;
beforeEach(() => {
process.env.TEST_ES_FROM = 'snapshot';

This comment has been minimized.

@tylersmalley

tylersmalley Mar 13, 2019

Member

Are we concerned with any of the possible ramifications of doing this when running parallel Jest tests?

This comment has been minimized.

@spalger

spalger Mar 13, 2019

Author Member

No, jest mocks out the env so each test file has its own and each is run in a separate process anyway.


if [[ "$cloneAuthor/$cloneBranch" != "elastic/$KIBANA_PKG_BRANCH" ]]; then
echo " -> Setting TEST_ES_FROM=source so that ES in tests will be built from $cloneAuthor/$cloneBranch"
export TEST_ES_FROM=source

This comment has been minimized.

@tylersmalley

tylersmalley Mar 13, 2019

Member

We also need to account for if we are checking out against the PR authors elasticsearch ES branch.

This comment has been minimized.

@spalger

spalger Mar 13, 2019

Author Member

This will trigger any time we are not checking out elastic/master, or elastic/6.x, or whatever the branch in package.json is, so that should be covered.

@@ -86,6 +88,7 @@ function checkout_sibling {
}

checkout_sibling "elasticsearch" "${PARENT_DIR}/elasticsearch" "USE_EXISTING_ES"
export TEST_ES_FROM=source

This comment has been minimized.

@tylersmalley

tylersmalley Mar 13, 2019

Member

Let's add a note here to indicate this is forcing us to always run from source for the time being.

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Mar 13, 2019

A couple of comments, but overall I really like this change. Thoughts on forward porting these changes, with the exception of forcing all to build from source?

@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Mar 13, 2019

That's what #33036 is, it's all the changes except for the override, and is designed to go in and be backported to 6.6 before updating this PR to use it.

@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Mar 13, 2019

WELP, 6.6.3 snapshots exist now

@spalger spalger closed this Mar 13, 2019

@spalger spalger deleted the spalger:ci/6.6/es-from-source branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.