Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove license restrictions from License Management. #33046

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 12, 2019

Fixes #33029, which was introduced in #30845.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

Pinging @elastic/es-ui


// Apps which don't have any license restrictions will return undefined license check results.
if (licenseCheckResults) {
if (licenseCheckResults.status !== LICENSE_STATUS_VALID) {

This comment has been minimized.

@tylersmalley

tylersmalley Mar 12, 2019

Member

nit, but how about combining the if checks? licenseCheckResults && licenseCheckResults.status !== LICENSE_STATUS_VALID

This comment has been minimized.

@cjcenizal

cjcenizal Mar 12, 2019

Author Contributor

I deliberately separated them so it would be clearer which condition the comment applies to.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

cjcenizal commented Mar 12, 2019

Retest

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM, tested

@jen-huang
Copy link
Contributor

jen-huang left a comment

Code LGTM!

@cjcenizal cjcenizal merged commit 9b632d0 into elastic:master Mar 12, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:bug/license-management-no-license-restrictions branch Mar 12, 2019

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Mar 13, 2019

cjcenizal added a commit that referenced this pull request Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.