Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Removes gotoPage action in favor of setPage #33175
Navigating between pages of a workpad, and then using undo or using the browsers back button to go back would get the UI into a weird state. The ui would update properly, but the url would be unchanged, which would then break trying to navigate back to that page. For example, if you went from /page/1 to /page/2 and then did undo, the url stays /page/2 which makes it impossible to navigate to /page2/ (because to the router, it appears you are already there).
The cause of this issue is that in navigating to a /page/:id url, the router would fire an action that would also do a router navigation, so you were essentially navigating to the same page twice, making it require two undos to get back to where you want to be.