Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Handle privilege error during node precheck #33176

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@joshdover
Copy link
Member

joshdover commented Mar 13, 2019

Summary

Closes #33129

When the node version precheck was added in #31309, it was not made to handle users that did not have privilege to access the Nodes API, resulting in 500 error messages rather than the expected "You do not have sufficient privileges" error message.

This adds handling for a 403 response from Elasticsearch to display a different error message to the frontend.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@joshdover joshdover requested a review from tylersmalley Mar 13, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM, tested

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2019

@joshdover joshdover merged commit 689bba3 into elastic:master Mar 13, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

@joshdover joshdover deleted the joshdover:ua-privilege-error branch Mar 13, 2019

joshdover added a commit to joshdover/kibana that referenced this pull request Mar 13, 2019

[UA] Handle privilege error during node precheck (elastic#33176)
* [UA] Handle privilege error during node precheck

* Fix tests

joshdover added a commit to joshdover/kibana that referenced this pull request Mar 13, 2019

[UA] Handle privilege error during node precheck (elastic#33176)
* [UA] Handle privilege error during node precheck

* Fix tests

joshdover added a commit to joshdover/kibana that referenced this pull request Mar 13, 2019

[UA] Handle privilege error during node precheck (elastic#33176)
* [UA] Handle privilege error during node precheck

* Fix tests

joshdover added a commit that referenced this pull request Mar 14, 2019

[UA] Handle privilege error during node precheck (#33176) (#33200)
* [UA] Handle privilege error during node precheck

* Fix tests

joshdover added a commit that referenced this pull request Mar 14, 2019

[UA] Handle privilege error during node precheck (#33176) (#33199)
* [UA] Handle privilege error during node precheck

* Fix tests

@joshdover joshdover added the non-issue label Mar 14, 2019

joshdover added a commit to joshdover/kibana that referenced this pull request Mar 14, 2019

[UA] Handle privilege error during node precheck (elastic#33176)
* [UA] Handle privilege error during node precheck

* Fix tests

joshdover added a commit that referenced this pull request Mar 15, 2019

[UA] Handle privilege error during node precheck (#33176) (#33201)
* [UA] Handle privilege error during node precheck

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.