Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New platform dropdown #33520

Merged
merged 7 commits into from Mar 21, 2019

Conversation

@lizozom
Copy link
Contributor

commented Mar 19, 2019

Summary

Removed the directives

  • dropdown
  • dropdownToggle

Switched the following to use EUI dropdown

  • vega help menues
  • dev console help menu

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

@lizozom lizozom self-assigned this Mar 19, 2019

@lizozom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Replaced the Vega and Dev Console help menus with an EUI version.
Functionality didn't change, just the menus themselves.

image
image

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

Pinging @elastic/es-ui

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

@bmcconaghy

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

If I open a context menu and then click on another request that context menu stays open but is disembodied:
image

@bmcconaghy
Copy link
Contributor

left a comment

Found a small bug and a couple of typos, but mostly console part LGTM.

@lizozom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@bmcconaghy Can't reproduce this locally.
I'm on Chrome\FF on Ubuntu.
What exactly do you do? Open the menu and the click on another request inside the Console field?

lizozom added some commits Mar 20, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

@lizozom lizozom requested a review from elastic/ml-ui as a code owner Mar 20, 2019

@bmcconaghy

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@lizozom yup that was what I did. I'm on Chrome on Mac.

@peteharverson
Copy link
Contributor

left a comment

Removal of the ML test LGTM

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

@bmcconaghy
Copy link
Contributor

left a comment

code LGTM, the disembodied dropdown bug is benign and cosmetic and fairly edge-casey, so OK with merging.

@lizozom lizozom merged commit 3cc7025 into elastic:master Mar 21, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

lizozom added a commit to lizozom/kibana that referenced this pull request Mar 21, 2019

New platform dropdown (elastic#33520)
* Removed old dropdown code from dev tools consle

* Removed old dropdown from vega tools

* Deleted dropdown directives from angular bootstrap

* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)

lizozom added a commit that referenced this pull request Mar 21, 2019

New platform dropdown (#33520) (#33652)
* Removed old dropdown code from dev tools consle

* Removed old dropdown from vega tools

* Deleted dropdown directives from angular bootstrap

* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)

@stacey-gammon stacey-gammon referenced this pull request Mar 26, 2019

Open

Migrating away from ui/public #26505

35 of 93 tasks complete

@timroes timroes added the chore label Mar 27, 2019

alakahakai added a commit to alakahakai/kibana that referenced this pull request Apr 2, 2019

New platform dropdown (elastic#33520)
* Removed old dropdown code from dev tools consle

* Removed old dropdown from vega tools

* Deleted dropdown directives from angular bootstrap

* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)

@cjcenizal cjcenizal added the non-issue label May 7, 2019

@timroes timroes referenced this pull request Jun 5, 2019

Merged

Fix broken Vega context menu #38095

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.