Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] share sass build with script #34323

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
4 participants
@spalger
Copy link
Member

commented Apr 1, 2019

In order to enable building sass outside of the build process and the Kibana server (currently for canvas storybooks) I've moved the core of the sass build task to a shared helper and exposed a script for running this script with an optional --kibana-dir argument.

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 1, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 1, 2019

@clintandrewhall
Copy link
Contributor

left a comment

Looks good to me, with my novice knowledge of the space, but I have a question about ensuring the script indicates an exit.

import { REPO_ROOT } from '../constants';
import { buildSass } from './build_sass';

run(async ({ log, flags: { kibanaDir } }) => {

This comment has been minimized.

Copy link
@clintandrewhall

clintandrewhall Apr 2, 2019

Contributor

Since this is async, will the script still exit and allow a process to follow? I wouldn't want Storybook to start until this completes.

This comment has been minimized.

Copy link
@spalger

spalger Apr 2, 2019

Author Member

Yep, run() executes the async function and reflects its success/failure with the process exit code, so if this fails it will exit with a 1, and if it succeeds the process will exit with a 0

@tylersmalley
Copy link
Member

left a comment

LGTM

@spalger spalger merged commit 6703848 into elastic:master Apr 2, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

spalger added a commit to spalger/kibana that referenced this pull request Apr 2, 2019

spalger added a commit to spalger/kibana that referenced this pull request Apr 2, 2019

spalger added a commit that referenced this pull request Apr 2, 2019

spalger added a commit that referenced this pull request Apr 2, 2019

@spalger

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

7.x/7.1: 1acf424
7.0: 0a09367

@spalger spalger deleted the spalger:implement/scss-compile-script branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.