Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] update APM migration reindex script #34801

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@graphaelli
Copy link
Member

commented Apr 9, 2019

fixes:

  • setting user_agent.original from http headers
  • host.hostname ECS alignment under kubernetes

closes #34259

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 9, 2019

@graphaelli graphaelli requested a review from tylersmalley Apr 12, 2019

@graphaelli

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

Intended for backport to 7.0 post-merge

@@ -62,7 +62,7 @@ export const isLegacyApmIndex = (
// source: https://github.com/elastic/apm-integration-testing/blob/master/tests/server/test_upgrade.py
export const apmReindexScript = `
// add ecs version
ctx._source.ecs = ['version': '1.0.0-beta2'];
ctx._source.ecs = ['version': '1.1.0-dev'];

This comment has been minimized.

Copy link
@tylersmalley

tylersmalley Apr 12, 2019

Member

What is the dev pre-release tag for?

This comment has been minimized.

Copy link
@graphaelli

graphaelli Apr 12, 2019

Author Member

that matches the version of the published ecs schema 7.0.1 is aligned with. This is something inherited from libbeat, not directly set by apm-server

@tylersmalley
Copy link
Member

left a comment

Code LGTM

@graphaelli graphaelli merged commit bfa3077 into elastic:7.x Apr 12, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

@graphaelli graphaelli deleted the graphaelli:apm-migration-update-7.x branch Apr 12, 2019

graphaelli added a commit to graphaelli/kibana that referenced this pull request Apr 12, 2019

graphaelli added a commit that referenced this pull request Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.