Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application registration + move capability loading to frontend #35194

Merged

Conversation

Projects
None yet
4 participants
@joshdover
Copy link
Member

commented Apr 16, 2019

Summary

This PR allows apps to be registered with the ApplicationService, and then uses that list of Applications to populate uiCapabilities from the backend.

Apps vs. Legacy Apps

I'm distinguishing between apps registered by the new platform plugins and legacy apps registered from the LegacyService so that we can handle routing differently for each case in a future PR. Registering legacy apps is not exposed to new platform plugins.

Legacy NavLinks (uiExport/links)

I have not removed the uiExport for navlinks and no longer plan to do so. In order to be able to register legacy applications with the new platform, I will leave legacy navlinks in so that the LegacyService can register the legacy apps by reading this data.

When the Chrome NavLink APIs move to the new platform, the legacy code will still depend on this data for legacy chrome features we do not intend to support directly from Core (lastSubUrl for example).

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from cc37177 to a31ae9b Apr 16, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 16, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from a31ae9b to 9857f26 Apr 23, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 23, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 9857f26 to 8a5339e Apr 23, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 23, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 8a5339e to 87cb3a5 Apr 23, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 23, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 87cb3a5 to 3946531 Apr 23, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 23, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch 3 times, most recently from d81fbac to 9ef83f8 Apr 24, 2019

@joshdover joshdover changed the title [wip] Add application registration + move capabilitiy loading to frontend [wip] Add application registration + move capability loading to frontend Apr 24, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 24, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 9ef83f8 to 4803521 Apr 24, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Apr 24, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch 2 times, most recently from d50f57c to 3ea7f1b Apr 24, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 25, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 3ea7f1b to bed476e Apr 29, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 29, 2019

@joshdover

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 29, 2019

@joshdover joshdover requested review from eliperelman and kobelb Apr 29, 2019

@joshdover joshdover marked this pull request as ready for review Apr 29, 2019

@joshdover joshdover requested review from elastic/kibana-platform as code owners Apr 29, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 1, 2019

@joshdover

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link

commented May 1, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 2, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 2, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from dd2d3cc to 0068cd0 May 2, 2019

@joshdover joshdover requested review from elastic/apm-ui as code owners May 2, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 2, 2019

@joshdover

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@kobelb This has been updated to remove the injectedVar completely. uiCapabilities are now provided as part of the PluginSpec. I opted against using uiExports since this code does not need to be included in UI bundles and is only read on the server-side at this time.

@joshdover joshdover requested a review from kobelb May 2, 2019

@kobelb

kobelb approved these changes May 3, 2019

Copy link
Contributor

left a comment

These changes are great! Nice work!

@elasticmachine

This comment has been minimized.

Copy link

commented May 3, 2019

@joshdover joshdover force-pushed the joshdover:app-service/registration branch from 7090fb7 to f66c959 May 6, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 6, 2019

@joshdover joshdover merged commit 7e8ed15 into elastic:application-service May 6, 2019

43 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Licenses yarn run grunt licenses
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Server tests yarn run grunt test:server
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Jest node scripts/jest --ci --no-cache --verbose
Details
X-Pack Mocha yarn test
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
sasslint node scripts/sasslint
Details

@joshdover joshdover deleted the joshdover:app-service/registration branch May 6, 2019

@epixa epixa referenced this pull request May 10, 2019

Open

[browser] Application service #18843

5 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.