Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Internationalize Functions #36252

Merged
merged 6 commits into from
May 12, 2019

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented May 8, 2019

Summary

This implements localization for Canvas Functions.

This PR creates a strongly-typed dictionary of strings, allowing us to know if any strings are missing or misapplied. It also replaces some types with TS enums, which will make maintenance easier.

Testing

You can pass the test locale to the start script:

yarn start --i18n.locale=en-xa

Screen Shot 2019-05-09 at 5 37 12 PM
Screen Shot 2019-05-09 at 5 37 20 PM
Screen Shot 2019-05-09 at 5 37 56 PM

@clintandrewhall clintandrewhall added WIP Work in progress Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 v7.2.0 labels May 8, 2019
@clintandrewhall clintandrewhall requested a review from a team as a code owner May 8, 2019 04:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@clintandrewhall clintandrewhall changed the title [WIP] Canvas Function i18n [Canvas] Internationalize Functions May 9, 2019
@clintandrewhall clintandrewhall added review and removed WIP Work in progress labels May 9, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great for me.

I learned a lot looking through how you were able to do the types for this.

@clintandrewhall
Copy link
Contributor Author

Thanks so much, @crob611 !!

@clintandrewhall clintandrewhall merged commit ecd19d0 into elastic:master May 12, 2019
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request May 12, 2019
* Initial commit

* Refactor: divide and conquer

* Parameterize help definitions for translation

* Bug fixes

* Redundant naming removed
clintandrewhall added a commit that referenced this pull request May 12, 2019
* Initial commit

* Refactor: divide and conquer

* Parameterize help definitions for translation

* Bug fixes

* Redundant naming removed
@clintandrewhall clintandrewhall deleted the i18n-functions branch August 30, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.2.0 v8.0.0
Projects
I18n
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants