[Canvas] Internationalize Functions#36252
Merged
clintandrewhall merged 6 commits intoelastic:masterfrom May 12, 2019
Merged
Conversation
clintandrewhall
added
WIP
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
clintandrewhall
changed the title
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
crob611
approved these changes
May 10, 2019
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
This looks and works great for me.
I learned a lot looking through how you were able to do the types for this.
Contributor
Author
|
Thanks so much, @crob611 !! |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
May 12, 2019
* Initial commit * Refactor: divide and conquer * Parameterize help definitions for translation * Bug fixes * Redundant naming removed
clintandrewhall
added a commit
that referenced
this pull request
May 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements localization for Canvas Functions.
This PR creates a strongly-typed dictionary of strings, allowing us to know if any strings are missing or misapplied. It also replaces some types with TS enums, which will make maintenance easier.
Testing
You can pass the test locale to the start script:
yarn start --i18n.locale=en-xa