Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli/dev] allow running --dev without kibana.dev.yml #36400

Merged
merged 6 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@spalger
Copy link
Member

commented May 9, 2019

When trying to reproduce CI issues locally it is common for the settings devs use in kibana.dev.yml to conflict with the requirements of the test suites.

Since those suites define all the config they need I think we should disable the dev config when running test servers with --dev, and in order to do that I've implemented the --no-dev-config flag which can be passed to the core CLI when it's running from source.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

@spalger spalger requested a review from elastic/kibana-platform as a code owner May 11, 2019

@spalger spalger requested review from elastic/kibana-operations and removed request for elastic/kibana-platform May 11, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 20, 2019

@tylersmalley
Copy link
Member

left a comment

LGTM

@spalger spalger merged commit 5bc0352 into elastic:master May 20, 2019

43 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Licenses yarn run grunt licenses
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Server tests yarn run grunt test:server
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Jest node scripts/jest --ci --no-cache --verbose
Details
X-Pack Mocha yarn test
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
sasslint node scripts/sasslint
Details

spalger added a commit to spalger/kibana that referenced this pull request May 20, 2019

[cli/dev] allow running --dev without kibana.dev.yml (elastic#36400)
* [cli/dev] allow running --dev without kibana.dev.yml

* disable kibana.dev.yml for functional test servers

* [cli/dev] automatically strip xpack config when running --oss

* revert bad merge artifact

spalger added a commit that referenced this pull request May 20, 2019

[7.x] [cli/dev] allow running --dev without kibana.dev.yml (#36400) (#…
…36707)

* [cli/dev] allow running --dev without kibana.dev.yml

* disable kibana.dev.yml for functional test servers

* [cli/dev] automatically strip xpack config when running --oss

* revert bad merge artifact
@spalger

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

7.x/7.2: 3bb33c0

@spalger spalger deleted the spalger:implement/no-dev-config branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.