Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Use mapbox feature-state for dynamic properties and upgrade mapbox-gl to 0.54 #36466
[Maps] Use mapbox feature-state for dynamic properties and upgrade mapbox-gl to 0.54 #36466
Changes from 21 commits
5e96dcb
25bd3ab
a718d17
4408c0a
1164f41
d11960b
bc24e1e
391927e
e267179
5f63b1b
2688683
8475426
2d1af32
de629c1
ef4c39c
85cbfe2
a1fb722
92f6128
6405ad1
5a77540
03c5576
f63c4af
673fef3
8da6521
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a breaking change. What if the vector source populates
id
field and users expect to see theirid
value in a tooltip and now they see our implementation value. Maybe not a big dealThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature#id
is not accessible as a tooltip-value. Only index-pattern properties are accessible, and they are put as-is underFeature#properties