Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] upgrade wreck #36527

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
4 participants
@toddself
Copy link
Contributor

commented May 13, 2019

Summary

wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck

For some reason prettier did a number on this...

[chore] upgrade wreck
wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck

@toddself toddself requested a review from elastic/kibana-operations as a code owner May 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 13, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

commented May 13, 2019

LGTM - tested, including Console

@toddself toddself merged commit 5f56c30 into elastic:master May 13, 2019

43 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Licenses yarn run grunt licenses
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Server tests yarn run grunt test:server
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Jest node scripts/jest --ci --no-cache --verbose
Details
X-Pack Mocha yarn test
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
sasslint node scripts/sasslint
Details

@toddself toddself deleted the toddself:upgrade-wreck branch May 13, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 13, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Added labels - would you mind backporting to the 7.x branch?

@toddself

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@tylersmalley gladly

toddself added a commit to toddself/kibana that referenced this pull request May 14, 2019

[chore] upgrade wreck (elastic#36527)
wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck
@toddself

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

toddself added a commit that referenced this pull request May 14, 2019

[chore] upgrade wreck (#36527)
wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck

toddself added a commit that referenced this pull request May 15, 2019

[chore] upgrade wreck (#36527) (#36552)
wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck
@clintandrewhall

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

I just pulled master, and yarn kbn bootstrap results in an updated yarn.lock file. Did something get missed? Didn't we pin core-js to avoid IE 11 bugs, or was that an issue in x-pack?

Screen Shot 2019-05-19 at 2 17 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.