From f1bfe0d9bb6ba3c748737b3cc16df735dc7da82c Mon Sep 17 00:00:00 2001 From: FrankHassanabad Date: Tue, 28 May 2019 11:20:28 -0600 Subject: [PATCH 1/2] Fixed unescaped HTML entity issue * Turned on linter rule to be an error * Removed the extra character * https://github.com/elastic/ingest-dev/issues/467 --- .eslintrc.js | 2 +- .../plugins/siem/public/components/event_details/json_view.tsx | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 885397a37d563c..6591fdd0303ee9 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -555,7 +555,7 @@ module.exports = { 'react/no-this-in-sfc': 'error', // This can go from warn to error once this is fixed // https://github.com/elastic/ingest-dev/issues/467 - 'react/no-unescaped-entities': 'warn', + 'react/no-unescaped-entities': 'error', 'react/no-unsafe': 'error', 'react/no-unused-prop-types': 'error', 'react/no-unused-state': 'error', diff --git a/x-pack/plugins/siem/public/components/event_details/json_view.tsx b/x-pack/plugins/siem/public/components/event_details/json_view.tsx index 1e9c8ca2fcea13..230ca10a7996f3 100644 --- a/x-pack/plugins/siem/public/components/event_details/json_view.tsx +++ b/x-pack/plugins/siem/public/components/event_details/json_view.tsx @@ -37,7 +37,6 @@ export const JsonView = pure(({ data }) => ( )} width="100%" /> - } )); From c912e8c03fc35f951bc4ada4e06c3805ac061e41 Mon Sep 17 00:00:00 2001 From: FrankHassanabad Date: Tue, 28 May 2019 11:36:44 -0600 Subject: [PATCH 2/2] Removed extra comment above the linter rule --- .eslintrc.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 6591fdd0303ee9..01102333c1058d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -553,8 +553,6 @@ module.exports = { 'react/no-typos': 'error', 'react/no-string-refs': 'error', 'react/no-this-in-sfc': 'error', - // This can go from warn to error once this is fixed - // https://github.com/elastic/ingest-dev/issues/467 'react/no-unescaped-entities': 'error', 'react/no-unsafe': 'error', 'react/no-unused-prop-types': 'error',