Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces API - default disabledFeatures to empty array #40017

Merged
merged 2 commits into from Jul 1, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Jul 1, 2019

Summary

Fixes #40014

The disabledFeatures property is optional on the Spaces API. When not specified, we should default this property to an empty array.

"Release notes: Fixes scenario where a Space is created via the API without specifying any disabledFeatures"

@legrego legrego added release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature labels Jul 1, 2019
@legrego legrego requested a review from a team as a code owner July 1, 2019 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member Author

legrego commented Jul 1, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego requested a review from kobelb July 1, 2019 17:03
@legrego legrego merged commit 544ef71 into elastic:master Jul 1, 2019
@legrego legrego deleted the spaces/df-api-fix branch July 1, 2019 17:16
legrego added a commit to legrego/kibana that referenced this pull request Jul 1, 2019
* default disabledFeatures to empty array

* update PUT spaces tests
legrego added a commit to legrego/kibana that referenced this pull request Jul 1, 2019
* default disabledFeatures to empty array

* update PUT spaces tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Security/Spaces Platform Security - Spaces feature release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.2.1 v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spaces] missing optional parameter disabledFeatures results in internal error
3 participants