Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node options Initialization on our scripts #40302

Merged
merged 13 commits into from Aug 15, 2019

Conversation

@mistic
Copy link
Member

commented Jul 3, 2019

That PR improves our usage of the NODE_OPTIONS env var re-exporting the NODE_OPTIONS with our enforced default options.

That is needed because right now we are not correctly pass along the inherit NODE_OPTIONS so for example the child processes of the thread-loader are not receiving them.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 3, 2019

@tylersmalley tylersmalley changed the title Update node options initialisation on our scripts Update node options Initialization on our scripts Jul 8, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 18, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 24, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 30, 2019

Show resolved Hide resolved bin/kibana Outdated
@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 1, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 1, 2019

@jbudz

jbudz approved these changes Aug 1, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 1, 2019

@mistic

This comment was marked as outdated.

Copy link
Member Author

commented Aug 1, 2019

retest

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 1, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 1, 2019

@mistic mistic force-pushed the mistic:improve-node-options-usage branch from 8ebb937 to b9db4c5 Aug 1, 2019

mistic added some commits Aug 1, 2019

@mistic mistic requested a review from elastic/kibana-operations as a code owner Aug 2, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 2, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 2, 2019

mistic added some commits Aug 2, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 2, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

@tylersmalley
Copy link
Member

left a comment

LGTM - tested on Windows

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

This good to merge?

@mistic

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@mistic mistic merged commit f9fbc5d into elastic:master Aug 15, 2019

50 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/linux-immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup10/node/linux-immutable/install/kibana --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/linux-immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/linux-immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/linux-immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/linux-immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/linux-immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/linux-immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/install/kibana --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup9/node/linux-immutable/install/kibana --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated run `node scripts/update_prs 40302` to update
prbot:release note labels
sasslint node scripts/sasslint
Details
@mistic

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

7.x: 28fca42

mistic added a commit to mistic/kibana that referenced this pull request Aug 15, 2019

Update node options Initialization on our scripts (elastic#40302)
* chore(NA): update node options initilization on our scripts

* chore(NA): re-export NODE_OPTIONS instead of re-setting on vars

* chore(NA): missing doc comment

chrisronline added a commit to chrisronline/kibana that referenced this pull request Aug 15, 2019

Update node options Initialization on our scripts (elastic#40302)
* chore(NA): update node options initilization on our scripts

* chore(NA): re-export NODE_OPTIONS instead of re-setting on vars

* chore(NA): missing doc comment

mistic added a commit that referenced this pull request Aug 15, 2019

Update node options Initialization on our scripts (#40302) (#43358)
* chore(NA): update node options initilization on our scripts

* chore(NA): re-export NODE_OPTIONS instead of re-setting on vars

* chore(NA): missing doc comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.